add deterministic notification pipeline smoke test - #802
Open
canicefavour wants to merge 4 commits into
Open
canicefavour wants to merge 4 commits into
canicefavour wants to merge 4 commits into
Conversation
|
@canicefavour Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented a fast, deterministic smoke test covering the notification lifecycle from local event ingestion through notification payload generation, without relying on external notification providers.
Implementation
Added a dedicated smoke test covering the local notification ingestion and processing pipeline.
Exercised event validation, routing, notification template resolution, and internal dispatching.
Added mocked/in-memory delivery handling to isolate the pipeline from external push, email, SMS, and webhook providers.
Verified representative event payloads are processed successfully through the notification workflow.
Asserted generated notification payloads for the expected recipient, title, body, and metadata.
Verified the mocked transport receives the generated notification exactly once.
Confirmed no real outbound network requests are made during the test.
Added bounded asynchronous handling and clean teardown to prevent hanging test processes.
Ensured the smoke test runs without external credentials, databases, or third-party API dependencies.
Added a dedicated command for executing the smoke test locally and in CI.
Documented the execution requirements and offline CI assumptions.
Verified the test completes quickly and deterministically with clean process termination.
Result
The notification system now has an isolated end-to-end smoke check that provides rapid CI feedback on event processing and notification generation while remaining fully offline and independent of external delivery services.
Closes #723